Set cookie value before handling side-effects (#76)

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### changed
+
+- Set cookie value before handling side-effects.
+
 ## [5.1.0]
 
 A new feature! This time it's an "overlay" on the entire website to block access whilst the cookiebar is displayed.

src/index.js

@@ -117,6 +117,8 @@ class CookieConsent extends Component {
    */
   accept({ acceptedByScrolling = false }) {
     const { cookieName, cookieValue, hideOnAccept, onAccept } = this.props;
+    
+    this.setCookie(cookieName, cookieValue);
 
     // fire onAccept
     onAccept({ acceptedByScrolling });
@@ -124,8 +126,6 @@ class CookieConsent extends Component {
     // remove listener if set
     window.removeEventListener("scroll", this.handleScroll);
 
-    this.setCookie(cookieName, cookieValue);
-
     if (hideOnAccept) {
       this.setState({ visible: false });
     }
@@ -144,17 +144,17 @@ class CookieConsent extends Component {
       extraCookieOptions,
       setDeclineCookie,
     } = this.props;
-
+    
+    if (setDeclineCookie) {
+      this.setCookie(cookieName, declineCookieValue);
+    }
+    
     // fire onDecline
     onDecline();
 
     // remove listener if set
     window.removeEventListener("scroll", this.handleScroll);
 
-    if (setDeclineCookie) {
-      this.setCookie(cookieName, declineCookieValue);
-    }
-
     if (hideOnDecline) {
       this.setState({ visible: false });
     }