mastermindzh/rickvanlieshout.com
1
0
Fork 0
mirror of https://github.com/mastermindzh/rickvanlieshout.com synced 2025-01-27 05:51:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes a crash when a post has no tag

Browse Source 
This commit avoids undefined.map() or null.map() is calling.

When there is no tag in a post, there are two cases in frontmatter.

1)
title: title
categories: Technical
...

2)
title: title
tags:
categories: Technical
...

Let's look at `post.node.frontmatter.tags` in both situations.
`FILE1 = /gatsby-node.js`
`FILE2 = /src/components/PostTemplateDetails/index.jsx`

In the first case, it is `undefined` in `FILE1`.
Cheking `undefined` is already implemented at FILE1#126, so undefined.map()
is not called.
But it is `null` in `FILE2#22`
and a crash will be occurred because it tries to run `null.map()`.

In the second case, it is `null` in `FILE1` and `FILE2`.
In this case, there will be two crashes in both files because both codes
try to run `null.map()`.

This commit avoids these crashes.
This commit is contained in:
ybbarng 2017-10-30 22:50:27 +09:00
parent dbba39f0ab
commit d207f68e43
No known key found for this signature in database
GPG Key ID: 80C507AF0D39B643
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gatsby-node.js
View File

@ -123,7 +123,7 @@ exports.onCreateNode = ({ node, boundActionCreators, getNode }) => {
value: slug value: slug
}); });
if (typeof node.frontmatter.tags !== 'undefined') { if (node.frontmatter.tags) {
const tagSlugs = node.frontmatter.tags.map( const tagSlugs = node.frontmatter.tags.map(
tag => `/tags/${_.kebabCase(tag)}/` tag => `/tags/${_.kebabCase(tag)}/`
); );

2
src/components/PostTemplateDetails/index.jsx
View File

@ -19,7 +19,7 @@ class PostTemplateDetails extends React.Component {
const tagsBlock = ( const tagsBlock = (
<div className="post-single__tags"> <div className="post-single__tags">
<ul className="post-single__tags-list"> <ul className="post-single__tags-list">
{tags.map((tag, i) => {tags && tags.map((tag, i) =>
<li className="post-single__tags-list-item" key={tag}> <li className="post-single__tags-list-item" key={tag}>
<Link to={tag} className="post-single__tags-list-item-link"> <Link to={tag} className="post-single__tags-list-item-link">
{post.frontmatter.tags[i]} {post.frontmatter.tags[i]}