mastermindzh/tidal-hifi
1
0
Fork 0
mirror of https://github.com/Mastermindzh/tidal-hifi.git synced 2024-11-22 13:32:42 +01:00
Code Issues Projects Releases Wiki Activity

Links in the about window now open in the user's default browser. fixes #360

Browse Source
This commit is contained in:
Rick van Lieshout 2024-03-24 15:55:33 +01:00
parent fd0dae2762
commit 4ef76c262e
4 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- TIDAL will now close the previous notification if a new one is sent whilst the old is still visible. [#364](https://github.com/Mastermindzh/tidal-hifi/pull/364) - TIDAL will now close the previous notification if a new one is sent whilst the old is still visible. [#364](https://github.com/Mastermindzh/tidal-hifi/pull/364)
- Updated developer documentation to get started in README [#365](https://github.com/Mastermindzh/tidal-hifi/pull/365) - Updated developer documentation to get started in README [#365](https://github.com/Mastermindzh/tidal-hifi/pull/365)
- - Links in the about window now open in the user's default browser. fixes [#360](https://github.com/Mastermindzh/tidal-hifi/issues/360)
## [5.9.0] ## [5.9.0]

12
src/pages/settings/settings.html
View File

@ -432,14 +432,14 @@
<img alt="tidal icon" class="about-section__icon" src="./icon.png" /> <img alt="tidal icon" class="about-section__icon" src="./icon.png" />
<h4>TIDAL Hi-Fi</h4> <h4>TIDAL Hi-Fi</h4>
<div class="about-section__version"> <div class="about-section__version">
<a href="https://github.com/Mastermindzh/tidal-hifi/releases/tag/5.10.0">5.10.0</a> <a target="_blank" href="https://github.com/Mastermindzh/tidal-hifi/releases/tag/5.10.0">5.10.0</a>
</div> </div>
<div class="about-section__links"> <div class="about-section__links">
<a href="https://github.com/mastermindzh/tidal-hifi/" class="about-section__button">Github <i <a target="_blank" href="https://github.com/mastermindzh/tidal-hifi/" class="about-section__button">Github
class="fa fa-external-link"></i></a> <i class="fa fa-external-link"></i></a>
<a href="https://github.com/Mastermindzh/tidal-hifi/issues" class="about-section__button">Report an issue <i <a target="_blank" href="https://github.com/Mastermindzh/tidal-hifi/issues"
class="fa fa-external-link"></i></a> class="about-section__button">Report an issue <i class="fa fa-external-link"></i></a>
<a href="https://github.com/Mastermindzh/tidal-hifi/graphs/contributors" <a target="_blank" href="https://github.com/Mastermindzh/tidal-hifi/graphs/contributors"
class="about-section__button">Contributors <i class="fa fa-external-link"></i></a> class="about-section__button">Contributors <i class="fa fa-external-link"></i></a>
</div> </div>
</section> </section>

1
src/pages/settings/settings.scss
View File

@ -415,7 +415,6 @@ html {
} }
// file upload // file upload
.file-drop-area { .file-drop-area {
position: relative; position: relative;
display: flex; display: flex;

6
src/scripts/settings.ts
View File

@ -1,6 +1,6 @@
import Store from "electron-store"; import Store from "electron-store";
import { BrowserWindow } from "electron"; import { BrowserWindow, shell } from "electron";
import path from "path"; import path from "path";
import { settings } from "../constants/settings"; import { settings } from "../constants/settings";
@ -134,6 +134,10 @@ export const createSettingsWindow = function () {
settingsWindow.loadURL(`file://${__dirname}/../pages/settings/settings.html`); settingsWindow.loadURL(`file://${__dirname}/../pages/settings/settings.html`);
settingsWindow.webContents.setWindowOpenHandler(({ url }) => {
shell.openExternal(url);
return { action: "deny" };
});
settingsModule.settingsWindow = settingsWindow; settingsModule.settingsWindow = settingsWindow;
}; };