Muting artists automatically (#116)

Co-authored-by: Cukmekerb <cukmekerb@gmail.com>
2025-07-28 00:22:26 +02:00 · 2022-03-31 17:37:12 +02:00
parent 0583c4a188
commit 6a7b3eefd4
13 changed files with 143 additions and 38 deletions
--- a/src/constants/settings.js
+++ b/src/constants/settings.js
@@ -13,6 +13,8 @@ const settings = {
  api: "api",
  menuBar: "menuBar",
  playBackControl: "playBackControl",
+  muteArtists: "muteArtists",
+  mutedArtists: "mutedArtists",
  apiSettings: {
    root: "apiSettings",
    port: "apiSettings.port",
--- a/src/pages/settings/preload.js
+++ b/src/pages/settings/preload.js
@@ -1,8 +1,15 @@
-let notifications;
-let playBackControl;
-let api;
-let port;
-let menuBar;
+let trayIcon,
+  minimizeOnClose,
+  mpris,
+  enableCustomHotkeys,
+  enableDiscord,
+  muteArtists,
+  notifications,
+  playBackControl,
+  api,
+  port,
+  menuBar,
+  mutedArtists;

 const { store, settings } = require("./../../scripts/settings");
 const { ipcRenderer } = require("electron");
@@ -22,6 +29,8 @@ function refreshSettings() {
  enableCustomHotkeys.checked = store.get(settings.enableCustomHotkeys);
  enableDiscord.checked = store.get(settings.enableDiscord);
  minimizeOnClose.checked = store.get(settings.minimizeOnClose);
+  muteArtists.checked = store.get(settings.muteArtists);
+  mutedArtists.value = store.get(settings.mutedArtists).join("\n");
 }

 /**
@@ -67,6 +76,13 @@ window.addEventListener("DOMContentLoaded", () => {
    });
  }

+  function addTextAreaListener(source, key) {
+    source.addEventListener("input", function (event, data) {
+      store.set(key, source.value.split("\n"));
+      ipcRenderer.send(globalEvents.storeChanged);
+    });
+  }
+
  ipcRenderer.on("refreshData", () => {
    refreshSettings();
  });
@@ -85,6 +101,8 @@ window.addEventListener("DOMContentLoaded", () => {
  mpris = get("mprisCheckbox");
  enableCustomHotkeys = get("enableCustomHotkeys");
  enableDiscord = get("enableDiscord");
+  muteArtists = get("muteArtists");
+  mutedArtists = get("mutedArtists");

  refreshSettings();

@@ -98,4 +116,6 @@ window.addEventListener("DOMContentLoaded", () => {
  addInputListener(enableCustomHotkeys, settings.enableCustomHotkeys);
  addInputListener(enableDiscord, settings.enableDiscord);
  addInputListener(minimizeOnClose, settings.minimizeOnClose);
+  addInputListener(muteArtists, settings.muteArtists);
+  addTextAreaListener(mutedArtists, settings.mutedArtists);
 });
--- a/src/pages/settings/settings.html
+++ b/src/pages/settings/settings.html
@@ -2,6 +2,7 @@
 <html lang="en">

 <head>
+    <title>Tidal-hifi settings</title>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <meta http-equiv="X-UA-Compatible" content="ie=edge" />
@@ -54,6 +55,17 @@
                                <span class="slider round"></span>
                            </label>
                        </div>
+                        <div class="option">
+                            <h4>Mute Artists automatically</h4>
+                            <p>
+                                The following list of artists (1 per line) will be muted automatically.
+                            </p>
+                            <label class="switch" style="margin-bottom:10px">
+                              <input id="muteArtists" type="checkbox">
+                              <span class="slider round" ></span>
+                          </label>
+                          <textarea id="mutedArtists" cols="40" rows="5"></textarea>
+                        </div>
                    </div>
                    <div class="section">
                        <h3>UI</h3>
@@ -139,12 +151,12 @@
                  <div class="section">
                      <h3>integrations</h3>
                      <p style="margin-bottom: 15px;">
-                          Tidal-hifi is extensible trough the use of integrations. You can enable or disable integrations here
+                          Tidal-hifi is extensible through the use of integrations. You can enable or disable integrations here
                      </p>
                      <div class="option">
-                          <h4>mpris-player</h4>
+                          <h4>MPRIS-player</h4>
                          <p>
-                              Whether to enable the mpris media player controls for Linux systems
+                              Whether to enable the MPRIS media player controls for Linux systems
                          </p>
                          <label class="switch">
                              <input id="mprisCheckbox" type="checkbox">
@@ -165,16 +177,16 @@
              </section>
                <section id="about" class="tab-panel">
                  <div class="section">
-                    <img style="width: 100px; height: auto; display: block; margin: 0 auto; margin-bottom: 20px; margin-top: 20px;" src = "./icon.png">
+                    <img alt="tidal icon" style="width: 100px; height: auto; display: block; margin: 0 auto; margin-bottom: 20px; margin-top: 20px;" src = "./icon.png">
                    <p style="max-width: 350px; display:block; margin: 0 auto; text-align: center;">
                      <a href ="javascript:openExternal('https://github.com/Mastermindzh/tidal-hifi');">Tidal-hifi</a> is made by <a href ="javascript:openExternal('https://www.rickvanlieshout.com')">Rick van Lieshout</a>.<br />
-                      It uses <a href="javascript:openExternal('https://castlabs.com/');">castlabs</a> versions of Electron for widevine support.
+                      It uses <a href="javascript:openExternal('https://castlabs.com/');">Castlabs'</a> versions of Electron for widevine support.
                    </p>

                  </div>
                </section>

-              <small>Some settings require a restart of Tidal-hifi. To do so click the button below:</small>
+              <small>Some settings require a restart of Tidal-hifi. To do so, click the button below:</small>
              <button onClick="restart()" style ="width: 100%">Restart Tidal-hifi</button>
            </div>
        </div>
@@ -469,5 +481,19 @@
    button:hover{
      background-color: rgba(229,238,255,.3);
    }
+    textarea {
+      color: #72777f;
+      background: #242528;
+      border: 0;
+      width: 100%;
+      color: rgba(229, 238, 255, .6);
+      padding: 0 0 12px;
+      display:block;
+    }
+    textarea:focus {
+      outline: none;
+      border: 0;
+      border-bottom: 1px solid #0ff;
+    }
 </style>
 </html>
--- a/src/preload.js
+++ b/src/preload.js
@@ -15,6 +15,7 @@ let progressBarTime;
 let currentTimeChanged = false;
 let currentTime;
 let currentURL = undefined;
+let isMutedArtist = false;

 const elements = {
  play: '*[data-test="play"]',
@@ -42,7 +43,7 @@ const elements = {
  playing_title: 'span[data-test="table-cell-title"].css-geqnfr',
  album_name_cell: '[data-test="table-cell-album"]',
  tracklist_row: '[data-test="tracklist-row"]',
-
+  volume: '*[data-test="volume"]',
  /**
   * Get an element from the dom
   * @param {*} key key in elements object to fetch
@@ -103,6 +104,10 @@ const elements = {
    return "";
  },

+  isMuted: function () {
+    return this.get("volume").getAttribute("aria-checked") === "false"; // it's muted if aria-checked is false
+  },
+
  /**
   * Shorthand function to get the text of a dom element
   * @param {*} key key in elements object to fetch
@@ -350,6 +355,8 @@ setInterval(function () {
  const progressBarTimeChanged = progressBarcurrentTime !== progressBarTime;
  const titleOrArtistChanged = currentSong !== songDashArtistTitle;

+  muteArtistIfFoundInMutedArtistsList();
+
  if (titleOrArtistChanged || playStatusChanged || progressBarTimeChanged || currentTimeChanged) {
    // update title, url and play info with new info
    setTitle(songDashArtistTitle);
@@ -404,6 +411,24 @@ setInterval(function () {
      () => {}
    );
  }
+
+  /**
+   * Checks whether the current artist is included in the "muted artists" list and if so it will automatically mute the player
+   */
+  function muteArtistIfFoundInMutedArtistsList() {
+    if (store.get(settings.muteArtists)) {
+      const mutedArtists = store.get(settings.mutedArtists);
+      if (mutedArtists.find((artist) => artist === artists) !== undefined) {
+        if (!elements.isMuted()) {
+          isMutedArtist = true;
+          elements.click("volume");
+        }
+      } else if (currentStatus === statuses.playing && isMutedArtist && elements.isMuted()) {
+        elements.click("volume");
+        isMutedArtist = false;
+      }
+    }
+  }
 }, 200);

 if (process.platform === "linux" && store.get(settings.mpris)) {
--- a/src/scripts/discord.js
+++ b/src/scripts/discord.js
@@ -32,7 +32,9 @@ const observer = (event, arg) => {
          startTimestamp: parseInt(now),
          endTimestamp: parseInt(remaining),
          largeImageKey: mediaInfoModule.mediaInfo.image,
-          largeImageText: (mediaInfoModule.mediaInfo.album) ? mediaInfoModule.mediaInfo.album : `${idleStatus.largeImageText}`,
+          largeImageText: mediaInfoModule.mediaInfo.album
+            ? mediaInfoModule.mediaInfo.album
+            : `${idleStatus.largeImageText}`,
          buttons: [{ label: "Play on Tidal", url: mediaInfoModule.mediaInfo.url }],
        },
      });
@@ -62,24 +64,32 @@ const idleStatus = {
 */
 discordModule.initRPC = function () {
  rpc = new discordrpc.Client({ transport: "ipc" });
-  rpc.login({ clientId }).catch(console.error);
-  discordModule.rpc = rpc;
+  rpc.login({ clientId }).then(
+    () => {
+      discordModule.rpc = rpc;

-  rpc.on("ready", () => {
-    rpc.setActivity(idleStatus);
-  });
-  ipcMain.on(globalEvents.updateInfo, observer);
+      rpc.on("ready", () => {
+        rpc.setActivity(idleStatus);
+      });
+      ipcMain.on(globalEvents.updateInfo, observer);
+    },
+    () => {
+      console.error("Can't connect to Discord, is it running?");
+    }
+  );
 };

 /**
 * Remove any RPC connection with discord and remove the event listener on globalEvents.updateInfo
 */
 discordModule.unRPC = function () {
-  rpc.clearActivity();
-  rpc.destroy();
-  rpc = false;
-  discordModule.rpc = rpc;
-  ipcMain.removeListener(globalEvents.updateInfo, observer);
+  if (rpc) {
+    rpc.clearActivity();
+    rpc.destroy();
+    rpc = false;
+    discordModule.rpc = undefined;
+    ipcMain.removeListener(globalEvents.updateInfo, observer);
+  }
 };

 module.exports = discordModule;
--- a/src/scripts/settings.js
+++ b/src/scripts/settings.js
@@ -10,12 +10,14 @@ const store = new Store({
    notifications: true,
    api: true,
    playBackControl: true,
+    muteArtists: false,
+    mutedArtists: ["Tidal"],
    menuBar: true,
    apiSettings: {
      port: 47836,
    },
    trayIcon: true,
-    minimizeOnClose : false,
+    minimizeOnClose: false,
    mpris: false,
    enableCustomHotkeys: false,
    enableDiscord: false,