feat: updated to electron 28. fixes #325

.stylelintrc.json

@@ -5,6 +5,9 @@
   "extends": [
     "stylelint-config-standard-scss"
   ],
+  "ignoreFiles": [
+    "src/themes/**.scss"
+  ],
   "rules": {
     "prettier/prettier": true,
     "scss/at-extend-no-missing-placeholder": null,

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [5.8.0]
+
+- Updated Electron to 28.1.1 for issue [325](https://github.com/Mastermindzh/tidal-hifi/issues/325)
+- Updated dependencies to latest
+  - added theme files to stylelint ignore
+  - fixed other stylelint errors
+
 ## [5.7.1]
 
 - Fixed mpris not being set up correctly due to capitalization of the instance name.

build/electron-builder.base.yml

@@ -1,7 +1,7 @@
 appId: com.rickvanlieshout.tidal-hifi
-electronVersion: 24.1.2
+electronVersion: 28.1.1
 electronDownload:
-  version: 24.1.2+wvcus
+  version: 28.1.1+wvcus
   mirror: https://github.com/castlabs/electron-releases/releases/download/v
 snap:
   plugs:

package.json

@@ -1,12 +1,13 @@
 {
   "name": "tidal-hifi",
-  "version": "5.7.1",
+  "version": "5.8.0",
   "description": "Tidal on Electron with widevine(hifi) support",
   "main": "ts-dist/main.js",
   "scripts": {
     "start": "electron --inspect=0.0.0.0:5858 .",
     "watchStart": "nodemon dist -x \"npm run start\"",
     "compile": "tsc && npm run sass-and-copy",
+    "deps": "npm run watch",
     "watch": "tsc-watch --onSuccess \"npm run sass-and-copy\"",
     "copy-files": "copyfiles -u 1 --exclude './src/**/*.ts' --exclude './src/**/*.scss' \"./src/**/*\" ts-dist",
     "copy-themes-dev": "copyfiles -u 1 \"./themes/*\" node_modules/electron/dist/resources",
@@ -38,38 +39,38 @@
   "homepage": "https://github.com/Mastermindzh/tidal-hifi",
   "license": "MIT",
   "dependencies": {
-    "@electron/remote": "^2.1.0",
-    "axios": "^1.6.4",
+    "@electron/remote": "^2.1.1",
+    "axios": "^1.6.5",
     "discord-rpc": "^4.0.1",
     "electron-store": "^8.1.0",
     "express": "^4.18.2",
-    "hotkeys-js": "^3.12.1",
+    "hotkeys-js": "^3.13.3",
     "mpris-service": "^2.1.2",
     "request": "^2.88.2",
-    "sass": "^1.69.5"
+    "sass": "^1.69.7"
   },
   "devDependencies": {
     "@mastermindzh/prettier-config": "^1.0.0",
-    "@types/discord-rpc": "^4.0.5",
-    "@types/express": "^4.17.17",
-    "@types/node": "^20.4.4",
-    "@types/request": "^2.48.8",
-    "@typescript-eslint/eslint-plugin": "^6.1.0",
-    "@typescript-eslint/parser": "^6.1.0",
+    "@types/discord-rpc": "^4.0.8",
+    "@types/express": "^4.17.21",
+    "@types/node": "^20.10.6",
+    "@types/request": "^2.48.12",
+    "@typescript-eslint/eslint-plugin": "^6.18.0",
+    "@typescript-eslint/parser": "^6.18.0",
     "copyfiles": "^2.4.1",
-    "electron": "git+https://github.com/castlabs/electron-releases.git#v24.1.2+wvcus",
-    "electron-builder": "^24.4.0",
-    "eslint": "^8.45.0",
+    "electron": "git+https://github.com/castlabs/electron-releases#v28.1.1+wvcus",
+    "electron-builder": "^24.9.1",
+    "eslint": "^8.56.0",
     "js-yaml": "^4.1.0",
     "markdown-toc": "^1.2.0",
-    "nodemon": "^3.0.1",
-    "prettier": "^3.0.0",
-    "stylelint": "^15.10.2",
-    "stylelint-config-standard": "^34.0.0",
-    "stylelint-config-standard-scss": "^10.0.0",
-    "stylelint-prettier": "^4.0.0",
+    "nodemon": "^3.0.2",
+    "prettier": "^3.1.1",
+    "stylelint": "^16.1.0",
+    "stylelint-config-standard": "^36.0.0",
+    "stylelint-config-standard-scss": "^13.0.0",
+    "stylelint-prettier": "^5.0.0",
     "tsc-watch": "^6.0.4",
-    "typescript": "^5.1.6"
+    "typescript": "^5.3.3"
   },
   "prettier": "@mastermindzh/prettier-config"
-}
+}

src/pages/settings/settings.html

@@ -389,7 +389,7 @@
           <img alt="tidal icon" class="about-section__icon" src="./icon.png" />
           <h4>TIDAL Hi-Fi</h4>
           <div class="about-section__version">
-            <a href="">5.7.1</a>
+            <a href="https://github.com/Mastermindzh/tidal-hifi/releases/tag/5.8.0">5.8.0</a>
           </div>
           <div class="about-section__links">
             <a href="https://github.com/mastermindzh/tidal-hifi/" class="about-section__button">Github <i
@@ -411,4 +411,4 @@
   </div>
 </body>
 
-</html>
+</html>

src/pages/settings/settings.scss

@@ -323,16 +323,19 @@ html {
     max-width: 500px;
     margin: -15px auto 0;
   }
+
   &__table {
     width: 120px;
-    margin: 0 auto 0;
+    margin: 0 auto;
 
     td {
       text-align: left;
     }
   }
+
   &__version {
-    margin: -10px 0px 30px 0px;
+    margin: -10px 0 30px;
+
     a {
       background-color: $tidal-grey-darker;
       border: none;
@@ -349,6 +352,7 @@ html {
   &__links {
     width: 300px;
     margin: 0 auto;
+
     a {
       border-radius: 10px;
       border: none;
@@ -418,10 +422,11 @@ html {
   align-items: center;
   width: 100%;
   max-width: 100%;
-  padding: 25px 0 25px 0px;
+  padding: 25px 0;
   border: 1px dashed $tidal-grey;
   border-radius: 3px;
   transition: 0.2s;
+
   &.is-active {
     background-color: $black;
   }
@@ -459,6 +464,7 @@ html {
   width: 100%;
   cursor: pointer;
   opacity: 0;
+
   &:focus {
     outline: none;
   }